-
Notifications
You must be signed in to change notification settings - Fork 150
chore: improve triage process #576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2413425
ci(stale bot): update conditions
Belco90 f54d760
ci(issue templates): create all issues with triage label
Belco90 29f04f3
ci(stale bot): fix typo
Belco90 724ec23
docs: add MAINTAINERS markdown file
Belco90 ca5dd91
docs: apply suggestions from PR
Belco90 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
This document outlines some processes that the maintainers should stick to. | ||
|
||
## Issues Process | ||
|
||
There are 3 types of issues that can be created: | ||
|
||
- `"bug"` | ||
- `"new rule"` | ||
- `"enhancement"` | ||
|
||
### Triage | ||
|
||
The triage process is basically making sure that the issue is correctly reported (and ask for more info if not), and categorize it correctly if it belongs to a different type than initially assigned. | ||
|
||
- When a new issue is created, they'll include a `"triage"` label | ||
- If the issue is correctly reported, please remove the `"triage"` label, so we know is valid and ready to be tackled | ||
- If the issue is **not** correctly reported, please ask for more details and add the `"awaiting response"` label, so we know more info has been requested to the author | ||
- If the issue belong to an incorrect category, please update the labels to put it in the right category | ||
- If the issue is duplicated, please close it including a comment with a link to the duplicating issue | ||
|
||
## Pull Requests Process | ||
|
||
### Main PR workflow | ||
|
||
_TODO: pending to describe the main PR process_ | ||
|
||
### Contributors | ||
|
||
When the PR gets merged, please check if the author of the PR or the closed issue (if any) should be added or updated in the [Contributors section](https://github.com/testing-library/eslint-plugin-testing-library#contributors-). | ||
|
||
If so, you can ask the [`@all-contributors` bot to add a contributor](https://allcontributors.org/docs/en/bot/usage) in a comment of the merged PR (this works for both adding and updating). Remember to check the [Contribution Types table](https://allcontributors.org/docs/en/emoji-key) to decide which sort of contribution should be assigned. | ||
|
||
## Stale bot | ||
|
||
This repo uses [probot-stale](https://github.com/probot/stale) to close abandoned issues and PRs after a period of inactivity. | ||
|
||
They'll be considered inactive if they match all the following conditions: | ||
|
||
- they have been 60 days inactive | ||
- they have at least one of the following labels: | ||
- `"awaiting response"`: we are waiting for more details but the author didn't react | ||
- `"new rule"`: there is a proposal for a new rule that no one could handle | ||
- `"enhancement"`: there is a proposal for an enhancement that no one could handle | ||
- `"invalid"`: something is wrong with the issue/PR and the author didn't take care of it | ||
|
||
When flagged as a stale issue or PR, they'll be definitely closed after 7 more days of inactivity. Issues and PRs with the following labels are excluded: `"pinned"`, `"security"`, and "`triage"`. Use the first one if you need to exclude an issue or PR from being closed for whatever reason even if the inactive criteria is matched. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.