Skip to content

chore: remove package lock #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore: remove package lock #228

wants to merge 1 commit into from

Conversation

nickserv
Copy link
Member

No description provided.

@Belco90
Copy link
Member

Belco90 commented Sep 10, 2020

What is the motivation for this PR?

@gndelia
Copy link
Collaborator

gndelia commented Sep 10, 2020

I believe here's the motivation

I'm not sure if I agree either but can't do more than that 🤷‍♂️

@Belco90
Copy link
Member

Belco90 commented Sep 10, 2020

I guess that's the reason, but not sure either if I agree.

@MichaelDeBoey
Copy link
Member

create-react-app (and a lot of other big packages) also ignores lock files: facebook/create-react-app#7789

@Belco90 Belco90 closed this in #232 Sep 20, 2020
@Belco90 Belco90 deleted the remove-package-lock branch September 20, 2020 16:55
@Belco90
Copy link
Member

Belco90 commented Oct 12, 2020

🎉 This issue has been resolved in version 3.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants