Breaking changes for next v5

[Belco90]

I have a couple of breaking changes I think we should introduce in the new major version taking advantage of having to support ESLint 8

This project is maintained by volunteers. Support will be added as time permits.

If you're not willing or able to help with adding support:

• Please do not raise issues.
• Please do not comment on threads.
• Please be patient and subscribe to this issue for updates.

This update will require breaking changes on our side as well, so it will take some time to support it.
There is no ETA on this work. Again please be patient.

---

✅ = done
🕐 = in progress
🔲 = not yet started

✅ Enable more rules in the shared configs

✅ no-render-in-setup

Enable for angular, react & vue configs (dom doesn't have a render method)

• feat(no-render-in-setup): add to Angular, React & Vue configs by default #481

✅ no-unnecessary-act

Enable for react configs

• feat(no-unnecessary-act): add to React config by default #468

✅ no-wait-for-multiple-assertions

Enable for all configs

• feat(no-wait-for-multiple-assertions): add to all configs by default #483

✅ no-wait-for-side-effects

Enable for all configs

• feat(no-wait-for-side-effects): add to all configs by default #484

✅ no-wait-for-snapshot

Enable for all configs

• feat(no-wait-for-snapshot): add to all configs by default #485

✅ prefer-presence-queries

Enable for all configs

• feat(prefer-presence-queries): add to all configs by default #486

✅ prefer-query-by-disappearance

Enable for all configs

• feat(prefer-query-by-disappearance): add to all configs by default #487

✅ Make isStrict option true by default for no-unnecessary-act

We have enabled this rule with isStrict to true in the shared configs, this option is still false by default. We should change it so it's true by default.

• feat(no-unnecessary-act): make isStrict option true by default #479

✅ Rules rename

We have some inconsistencies in naming some of our rules regarding using singular/plural.

✅ await-async-query -> await-async-queries

• feat(await-async-query): rename to await-async-queries #665

✅ no-await-sync-query -> no-await-sync-queries

• feat(no-await-sync-query): rename to no-await-sync-queries #666

✅ no-debug -> no-debugging-utils

• feat(no-debug): rename to no-debugging-utils #469

[MichaelDeBoey]

Enable more rules in the shared configs

I think we should enable these rules too:

• testing-library/no-render-in-setup
• testing-library/no-unnecessary-act (✅ done already)
• testing-library/no-wait-for-multiple-assertions
• testing-library/no-wait-for-side-effects
• testing-library/no-wait-for-snapshot
• testing-library/prefer-presence-queries
• testing-library/prefer-query-by-disappearance

Do we enable them in all configs or only in specific framework configs?

[no-unnecessary-act] Set isStrict to true by default

We have enabled this rule with isStrict to true in the shared configs, this option is still false by default. We should change it so it's true by default.

This means we can just make no-unnecessary-act an error in the React config

Rules renaming for consistency

We have some inconsistencies in naming some of our rules regarding using singular/plural.

At the moment we have:

• await-async-query
• no-await-sync-query
• prefer-presence-queries
• prefer-query-by-disappearance
• prefer-screen-queries

So query could have two meanings: the verb (to query) and the noun (a query). I think we should use the singular for the verb and the plural for the noun. All our usages are nouns, so all of them should be plural perhaps?

• await-async-queries
• no-await-sync-queries
• prefer-presence-queries
• prefer-queries-by-disappearance
• prefer-screen-queries

I think we should keep prefer-query-by-disappearance as this is about the specific queryBy* queries.
All others are more generic, so those are better to be made consistent indeed.

[Belco90]

Do we enable them in all configs or only in specific framework configs?

I'd say in all applicable ones:

• testing-library/no-render-in-setup: angular, react and vue (dom doesn't have a render method)
• testing-library/no-wait-for-multiple-assertions: all
• testing-library/no-wait-for-side-effects: all
• testing-library/no-wait-for-snapshot: all
• testing-library/prefer-presence-queries: all
• testing-library/prefer-query-by-disappearance: all

This means we can just make no-unnecessary-act an error in the React config

Indeed!

I think we should keep prefer-query-by-disappearance as this is about the specific queryBy* queries.
All others are more generic, so those are better to be made consistent indeed.

As you mentioned, this is about the specific queryBy* queries so that's why I suggested renaming to "queries" in that one too.