fix: make sure prefer-in-document only lint queries #105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Make sure the rule
prefer-in-document
only reports on what are actually queries from testing-library. If there's a variable passed to expect like so:expect(element).toBeDefined()
we don't really know what the value is.This change will make sure we only lint code like:
expect(screen.findByText('lorem ipsum')
andexpect(findByTextId('list-item')
This solves #104
How:
If
subject
is anything other thanCallExpression
the checker method bails early.Checklist: