Skip to content

fix(types): missing ignore parameter for SelectorMatcherOptions #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MatanBobi
Copy link
Member

@MatanBobi MatanBobi commented Mar 30, 2021

What: Add missing ignore parameter definition in type SelectorMatcherOptions.
From the docs and the codebase it looks like it can either be a string or a boolean.

Why: Resolves #921

How: Added the missing parameter manually.

Checklist:

  • Documentation added to the
    docs site
  • Tests
  • Typescript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 30, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5ecc890:

Sandbox Source
react-testing-library-examples Configuration
cranky-gauss-gc951 Issue #921
react-testing-library demo Issue #921

@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #924 (5ecc890) into master (bb83d8c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #924   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          948       948           
  Branches       287       287           
=========================================
  Hits           948       948           
Flag Coverage Δ
node-10.14.2 100.00% <ø> (ø)
node-12 100.00% <ø> (ø)
node-14 100.00% <ø> (ø)
node-15 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb83d8c...5ecc890. Read the comment docs.

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eps1lon eps1lon added the bug Something isn't working label Mar 30, 2021
@MatanBobi MatanBobi merged commit 2c9e2c1 into testing-library:master Mar 31, 2021
@MatanBobi MatanBobi deleted the pr/fix-missing-parameter-for-matcher branch March 31, 2021 08:19
@github-actions
Copy link

🎉 This PR is included in version 7.30.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickserv
Copy link
Member

@all-contributors add @MatanBobi for code

@allcontributors
Copy link
Contributor

@nickmccurdy

I've put up a pull request to add @MatanBobi! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

*ByText options has incorrect type
4 participants