-
Notifications
You must be signed in to change notification settings - Fork 469
fix(types): missing ignore parameter for SelectorMatcherOptions #924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): missing ignore parameter for SelectorMatcherOptions #924
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5ecc890:
|
Codecov Report
@@ Coverage Diff @@
## master #924 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 948 948
Branches 287 287
=========================================
Hits 948 948
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version 7.30.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
@all-contributors add @MatanBobi for code |
@nickmccurdy I've put up a pull request to add @MatanBobi! 🎉 |
What: Add missing
ignore
parameter definition in typeSelectorMatcherOptions
.From the docs and the codebase it looks like it can either be a string or a boolean.
Why: Resolves #921
How: Added the missing parameter manually.
Checklist:
docs site