feat: warn when the test environment fake timers change unexpectedly #832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9442fb0:
|
Codecov Report
@@ Coverage Diff @@
## master #832 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 923 934 +11
Branches 282 286 +4
=========================================
+ Hits 923 934 +11
Continue to review full report at Codecov.
|
nickserv
approved these changes
Nov 19, 2020
|
@all-contributors please add @nickmccurdy for review |
|
I've put up a pull request to add @nickmccurdy! 🎉 |
|
🎉 This PR is included in version 7.28.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: feat: warn when the test environment fake timers change unexpectedly
Why: Closes: #830
How: For every iteration of waitFor, it checks whether the state of fake timers has changed and if it has, it rejects with an error. Also supports the
showOriginalStackTraceconfig option.Checklist: