Skip to content

fix(TS): Recommend updating local type definitions #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

nickserv
Copy link
Member

What: Recommend updating local type definitions

Why: It seems like the types have moved back from DefinitelyTyped to this repository, so this repository should be used to maintain them instead of DefinitelyTyped (note that we also may need to remove them to reduce confusion, I'm not sure how though)

How: Updated pull request template

Checklist:

  • Documentation added to the
    docs site N/A
  • Tests N/A
  • Ready to be merged

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c1e5291:

Sandbox Source
heuristic-wood-0s97j Configuration

@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #621 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #621   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          558       558           
  Branches       140       140           
=========================================
  Hits           558       558           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b23a2bc...c1e5291. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kentcdodds kentcdodds merged commit 32dd725 into master Jun 12, 2020
@kentcdodds
Copy link
Member

Note, only use "fix" when you want to trigger a release 👍

@kentcdodds kentcdodds deleted the pr/recommend-updating-local-type-definitions branch June 12, 2020 03:29
@kentcdodds
Copy link
Member

🎉 This PR is included in version 7.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants