-
Notifications
You must be signed in to change notification settings - Fork 469
feat(waitFor): improve error message for non-function callbacks #515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 05aa661:
|
Codecov Report
@@ Coverage Diff @@
## master #515 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 426 428 +2
Branches 101 102 +1
=========================================
+ Hits 426 428 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just some minor nitpicks.
@Belco90 Looking good, thanks! |
🎉 This PR is included in version 7.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What:
Closes #509
Why:
To improve error message and error stack trace
How:
Checking if
callback
is a function.Checklist:
docs site
DefinitelyTyped