fix: use wait in findBy queries #469
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Using the
wait
method instead ofwaitForElement
for thefindBy
queriesWhy: To prevent that deprecations are logged
Closes #468
How: Replace
waitForElement
withwait
(and by renamingwaitForElementOptions
towaitOptions
)Checklist:
docs site
DefinitelyTyped
Something else that I've encountered, is that the changes made in #461 didn't make it into the beta branch.