Skip to content

fix: use wait in findBy queries #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2020
Merged

fix: use wait in findBy queries #469

merged 1 commit into from
Mar 7, 2020

Conversation

timdeschryver
Copy link
Member

What: Using the wait method instead of waitForElement for the findBy queries

Why: To prevent that deprecations are logged

Closes #468

How: Replace waitForElement with wait (and by renaming waitForElementOptions to waitOptions)

Checklist:

Something else that I've encountered, is that the changes made in #461 didn't make it into the beta branch.

This, to prevent that deprecations will be logged

Closes #468
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d39b665:

Sandbox Source
jolly-sara-05k0o Configuration

@codecov
Copy link

codecov bot commented Mar 7, 2020

Codecov Report

Merging #469 into beta will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           beta   #469   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files        22     22           
  Lines       420    419    -1     
  Branches    100    100           
===================================
- Hits        420    419    -1
Impacted Files Coverage Δ
src/query-helpers.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6d23dc...d39b665. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thank you!

@kentcdodds kentcdodds merged commit b3487d0 into beta Mar 7, 2020
@kentcdodds kentcdodds deleted the pr/findby-wait branch March 7, 2020 21:52
@timdeschryver
Copy link
Member Author

In case you missed it, while making these changes I saw the changes made in #461 didn't make it into the beta branch, and I'm not sure where these changes are...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants