Skip to content

Run Travis builds on Node 10.0.0 #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2020

Conversation

NMinhNguyen
Copy link
Contributor

What: Ensure we actually run builds against the lowest version of Node that we support

Why: Node 10.0.0 is our lowest version of support

How: Be specific about the version of Node in travis.yml - specifying just 10 pulls down the latest Node 10

Checklist:

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 308ca67:

Sandbox Source
intelligent-mayer-lud78 Configuration

@codecov
Copy link

codecov bot commented Mar 7, 2020

Codecov Report

Merging #467 into beta will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##           beta   #467   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files        22     22           
  Lines       420    420           
  Branches    100    100           
===================================
  Hits        420    420

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de9ac27...308ca67. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kentcdodds kentcdodds merged commit d6d23dc into testing-library:beta Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants