Skip to content

fix(ByDisplayValue): improve warning message #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2020

Conversation

xgbuils
Copy link
Contributor

@xgbuils xgbuils commented Feb 1, 2020

What:

  • Improve warning message in ByDisplayValue queries: "with the value:" -> "with the display value:"
  • Update snapshots for element not found error message.
  • Ensure that multiple elements error message is changed as expected (No test failed when message was changed).

Why:

As said in #442, the current message is quite misleading.

Checklist:

  • Documentation added to the
    docs site (N/A)
  • I've prepared a PR for types targeting
    DefinitelyTyped (N/A)
  • Tests
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 1, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dcfe27d:

Sandbox Source
kind-sara-2gn0y Configuration

@codecov
Copy link

codecov bot commented Feb 1, 2020

Codecov Report

Merging #443 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #443   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          22     22           
  Lines         384    384           
  Branches       90     90           
=====================================
  Hits          384    384
Impacted Files Coverage Δ
src/queries/display-value.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a62d82...dcfe27d. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super. Thank you!

@kentcdodds kentcdodds merged commit 686175a into testing-library:master Feb 1, 2020
@kentcdodds
Copy link
Member

@all-contributors please add @xgbuils for code and tests

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @xgbuils! 🎉

@kentcdodds
Copy link
Member

🎉 This PR is included in version 6.12.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants