fix(element-queries) jest/valid-title warning in test #437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the work test in the description
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 973664c:
|
Codecov Report
@@ Coverage Diff @@
## master #437 +/- ##
=======================================
Coverage ? 100%
=======================================
Files ? 22
Lines ? 384
Branches ? 90
=======================================
Hits ? 384
Misses ? 0
Partials ? 0Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 6.12.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the work test in the description
What:
Remove the word
testfrom test descriptiontest the debug helper prints the dom state herein element-queries fixes #436dom-testing-library/src/__tests__/element-queries.js
Line 680 in 3805b27
Why:
Running
npm run lintreturns a jest/valid-title warningHow:
Checklist:
docs site
DefinitelyTyped
No change to code and functionality and running
npm run test->areturns all test passing