feat(event): add new history popstate event #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added popstate to events map with respective tests #427 feat(event): simplify tests
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 66546ab:
|
Codecov Report
@@ Coverage Diff @@
## master #433 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 22 22
Lines 374 374
Branches 87 87
=====================================
Hits 374 374
Continue to review full report at Codecov.
|
kentcdodds
approved these changes
Jan 28, 2020
|
@all-contributors please add @seetdev for tests and code |
|
I've put up a pull request to add @seetdev! 🎉 |
Closed
9 tasks
|
🎉 This PR is included in version 6.12.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added popstate to events map with respective tests #427
What:
popstate history event is not supported.
Why:
Adding this event will allow the testing of custom router implementations
How:
Added new popstate event applicable on window.
Checklist:
docs site
DefinitelyTyped