Skip to content

chore(event): cleanup commented out code #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JonathanStoye
Copy link
Contributor

What/Why/How:

#423

Checklist:

  • Documentation added to the docs site N/A
  • I've prepared a PR for types targeting DefinitelyTyped N/A
  • Tests N/A
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 6, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 979d43d:

Sandbox Source
nervous-bird-hfzdi Configuration

@codecov
Copy link

codecov bot commented Jan 6, 2020

Codecov Report

Merging #425 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #425   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          22     22           
  Lines         374    374           
  Branches       87     87           
=====================================
  Hits          374    374
Impacted Files Coverage Δ
src/events.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fed5ae...979d43d. Read the comment docs.

@eps1lon
Copy link
Member

eps1lon commented Jan 6, 2020

I thought all the "all-contributors" related stuff is handled by a bot. Any reason this has to be included in this PR?

@JonathanStoye
Copy link
Contributor Author

@eps1lon I am sorry, it used to be that I have to do it myself last time I contributed here. Let me remove that real quick.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit 3f30564 into testing-library:master Jan 6, 2020
@kentcdodds
Copy link
Member

@all-contributors please add @JonathanStoye for code

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @JonathanStoye! 🎉

@kentcdodds
Copy link
Member

🎉 This PR is included in version 6.11.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants