Skip to content

test: Ensure broken node 16.9.0 isn't used #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 11, 2021
Merged

test: Ensure broken node 16.9.0 isn't used #1028

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e658fb
ensure we install past ^16.9.1?
eps1lon Sep 11, 2021
4131f81
Does this work for codecov
eps1lon Sep 11, 2021
135f09d
codecov doesn't like the caret
eps1lon Sep 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/validate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ jobs:
# Otherwise we would not know if the problem is tied to the Node.js version
fail-fast: false
matrix:
node: [12, 14, 16]
# TODO: relax `'16.9.1'` to `16` once GitHub has 16.9.1 cached. 16.9.0 is broken due to https://github.com/nodejs/node/issues/40030
node: [12, 14, '16.9.1']
Copy link
Member Author

@eps1lon eps1lon Sep 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't use '^16.9.1' because codecov flags do not support carets:

Flags Must consist only of alphanumeric characters, '_', '-', or '.' and not exceed 45 characters

-- https://docs.codecov.com/docs/flags

runs-on: ubuntu-latest
steps:
- name: 🛑 Cancel Previous Runs
Expand Down