"Please file an issue with the code that's causing you to see this error"

[jdevries3133]

Edit

Please see my last comment – this is a case of beginner's confusion but maybe a bit of a confusing error message as well.

• @testing-library/dom version: 7.30.0
• Testing Framework and version: @testing-library/react ^11.2.5
• DOM Environment: jest / jestdom

Relevant code or config

https://github.com/jdevries3133/song_maker_gallery/blob/12fcc5be423a8cdac1a439e9e35d8e6ab1fe9bc9/django_smg/frontend/src/components/teacher/teacher.test.js#L44

What you did: Working on some tests; I am still very new to testing-library and unit testing with React overall.

What happened:

I got this error message, so am opening an issue as requested:

Unable to find the "window" object for the given node. Please file an issue with the code that's causing you to see this error: https://github.com/testing-library/dom-testing-library/issues/new

Reproduction repository:
https://github.com/testing-library/dom-testing-library-template

Problem description: I got an error asking to open an issue.

Suggested solution: Who knows, but I hope this can help you trace down a bug if there is one. Let me know if you'd like any additional information.

[jdevries3133]

Full traceback:

[jdevries3133]

Ok, so I am new and I think I was just making a mistake; I switched from

  fireEvent.click(screen, "addSpreadsheetButton");
  fireEvent.click(screen, "verifyGroupButton");

to

  fireEvent.click(screen.getByTestId("addSpreadsheetButton"));
  fireEvent.click(screen.getByTestId("verifyGroupButton"));

After doing that, the spooky error went away. Obviously, it couldn't find the element because I was passing in a string, not a node (duh). Still, I mindlessly submitted this issue after seeing the error message. I wonder if it is possible to provide a more descriptive error in cases like this?

[MatanBobi]

Hi @jdevries3133, thanks for opening this :)
What would you think should be the error in that case?
The issue was that you passed in the screen object which is basically an object we create that contains all the queries attached to the document.body. That in fact really isn't a DOM node so it can't find the window attached to it.

[jdevries3133]

Yes, the first part of the error is good and accurate, I just don't think it should solicit a GitHub issue since it's a case of user error. It made me think that I had caused an unexpected exception and uncovered a problem in the library when that obviously wasn't the case.

[MatanBobi]

We can make a better error message here, maybe checking if the element is in fact an HTML element and only then ask the user to file an issue.
This function has some if statements already, I guess we can cover that case also.

dom-testing-library/src/helpers.js

Line 90 in 1b19094

function getWindowFromNode(node) {

[savcni01]

I plan to work on this issue today.

[github-actions]

🎉 This issue has been resolved in version 7.31.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀