Skip to content

Fix default branch CI build #663

Closed
@kentcdodds

Description

@kentcdodds

I think when I merged this PR I had assumed the build passed because of codecov's comment which shouldn't appear until we have a successful build. I'm still not sure what happened there to be honest.

But in any case, since that PR was merged (which really just updated aria-query) our tests have been failing. Mostly the suggestion tests, but some others as well.

Could someone dive in and help. You don't have to do it all. Even fixing a few would be helpful.

I think we could especially use help from @benmonro who wrote most of the suggestion tests. In particular, aria-query now gives us a role of generic for generic elements. I'm not 100% certain I want to recommend screen.getByRole('generic', {name: /bob/i}) over screen.getByText(/bob/i)... So I'm thinking we should probably skip that suggestion if the role is generic.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions