Skip to content

Upgrading pretty-format bumped the minimum Node version to 10.14.2 #563

Closed
@exogen

Description

@exogen

👋 Hello! I noticed that in between v7.2.2 and v7.3.0, there was a major upgrade to pretty-format. Unfortunately, this changes the minimum Node version, so it's possible to minor bump @testing-library/dom and not work with the same Node anymore.

  • @testing-library/dom version: v7.4.0
  • Testing Framework and version: jest@24.9.0
  • DOM Environment: jsdom@11.12.0

What you did:

$ yarn

What happened:

$ yarn
error pretty-format@26.0.1: The engine "node" is incompatible with this module. Expected version ">= 10.14.2". Got "10.13.0"
error Found incompatible module.

Problem description:

Due to the pretty-format major version bump in #546, the minimum Node version changed to 10.14.2 in between @testing-library/dom v7.2.2 and v7.3.0.

Given the value in engines and relatively recent #480, it seems intentional to support older Node 10 versions. (For reference, I ran into this because my current client happens to use images containing v10.13.0 for our deploys.)

Suggested solution:

Downgrade pretty-format back to v25, or update this package's stated support.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions