Skip to content

fix: allow cypress@v7 in peer dependency range #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Apr 6, 2021

What:

To not have a peer dep warning when installing

Why:

https://github.com/cypress-io/cypress/releases/tag/v7.0.0

How:

GH Editor

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@JeremyGrieshop
Copy link

NPM7 currently blocks installing cypress@7.x unless you use the --legacy-peer-deps option, so this is a requirement for that, I believe.

@SimenB
Copy link
Contributor Author

SimenB commented Apr 13, 2021

@nickmccurdy ping 🙂

@alexkrolick
Copy link
Contributor

image

CI is failing for some reason

@SimenB
Copy link
Contributor Author

SimenB commented Apr 15, 2021

Yeah, it seemed super transient, so I didn't bother. Retriggering seems to have fixed it 👍

@joelgrimberg
Copy link

so how long will it take to be released? can't wait :)

thanks to all of you for taking the effort!

@alexkrolick alexkrolick merged commit 8571177 into testing-library:master Apr 15, 2021
@github-actions
Copy link

🎉 This PR is included in version 7.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@alexkrolick
Copy link
Contributor

Sorry, walked away after re-triggering. Looks like release worked fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants