Fix findByRole() and findAllByRole() type definition to check role name #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicholasBoll
approved these changes
Feb 21, 2021
|
🎉 This PR is included in version 7.0.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Thank you for your great product. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix findByRole() and findAllByRole() type definition to check role name as same as upstream @testing-library/dom does.
Why:
Current type definition uses Matcher type this is for jQuery selector.
How:
Switch role name type to ByRoleMatcher that is used in @testing-library/dom.
Checklist:
I confirmed VSCode shows role names in completion word list.