Skip to content

Fix configureCypressTestingLibrary typings #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

Thisen
Copy link
Contributor

@Thisen Thisen commented Sep 22, 2020

What:

Fixes cy.configureCypressTestingLibrary(config) for TypeScript users. Fixes #143.
Also, ran prettier for the changed files.

Why:

Type safety. 🎉

How:

I've added a declaration for configureCypressTestingLibrary in the type definitions.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kentcdodds kentcdodds merged commit 85a8049 into testing-library:master Sep 22, 2020
@kentcdodds
Copy link
Member

@all-contributors please add @Thisen for code

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @Thisen! 🎉

@kentcdodds
Copy link
Member

@all-contributors please add @Thisen for code and tests

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @Thisen! 🎉

@Thisen
Copy link
Contributor Author

Thisen commented Sep 22, 2020

Always happy to help. 👏

@testing-library-bot
Copy link

🎉 This PR is included in version 7.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Property 'configureCypressTestingLibrary' does not exist on type 'cy & EventEmitter'
3 participants