Skip to content

chore(lint): re-enable eslint plugin angular #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 7, 2021
Merged

chore(lint): re-enable eslint plugin angular #237

merged 13 commits into from
Jul 7, 2021

Conversation

the-ult
Copy link
Contributor

@the-ult the-ult commented Jul 6, 2021 •
edited
Loading

Re-enable the eslint testing-library plugins.

  • and improve the eslint settings for other projects

fixes #235

arjen.althoff added 7 commits July 6, 2021 20:21
build(lint): re-add eslint-plugins
230c1a1 
Add it to main apps/example-app/eslint.json and projects/testing-library/eslint.json
, since rules apply only to jest test files. (Not to apps/example-app-karma

"plugin:jest/style",
"plugin:testing-library/angular",
"plugin:jest-dom/recommended"
fix(lint): apply linting autofix
faf5d96
fix(lint): fix linting errors
8440fd8
build(deps): update (es)linting dependencies
c8786e8
chore(example-app): add ScrollingModule to AppModule
2ac614b 
Needed for the 13-scrolling.component test. Which used  @angular/cdk/scrolling
build(lint): adjust settings for eslint
4788459 
Following the guide
https://github.com/testing-library/eslint-plugin-testing-library#run-the-plugin-only-against-test-files
fix(lint): fix additional linting errors
2ddaaca
the-ult
the-ult commented Jul 6, 2021
View reviewed changes
the-ult
the-ult commented Jul 6, 2021
View reviewed changes
the-ult
the-ult commented Jul 6, 2021
View reviewed changes
timdeschryver
timdeschryver reviewed Jul 6, 2021
View reviewed changes
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for creating the PR and fixing the lint issues!
I noticed some tests are changed from test to it, was there a reason for this?
I would prefer to just use one syntax, if a linter prefers it that's good for me.

@the-ult
Copy link
Contributor Author

the-ult commented Jul 7, 2021

Hi, thanks for creating the PR and fixing the lint issues!
I noticed some tests are changed from test to it, was there a reason for this?
I would prefer to just use one syntax, if a linter prefers it that's good for me.

These where indeed 'auto' fixed by the linter.

When a test is standalone. Use test()
Within a describe() use it()

@the-ult
Copy link
Contributor Author

the-ult commented Jul 7, 2021

Hey @timdeschryver,

I resolved / fixed your comments.
Thanks for the review 👍

@the-ult the-ult changed the title fix/re enable eslint plugin angular chore(lint): re-enable eslint plugin angular Jul 7, 2021
@timdeschryver
Copy link
Member

Ah I didn't know that.
Thanks for the info 👍

timdeschryver
timdeschryver reviewed Jul 7, 2021
View reviewed changes
@timdeschryver timdeschryver merged commit 221bf42 into testing-library:main Jul 7, 2021
@the-ult the-ult deleted the fix/re-enable-eslint-plugin-angular branch July 8, 2021 07:03
@github-actions
Copy link

🎉 This PR is included in version 10.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdeschryver timdeschryver timdeschryver approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Regression] ESLint plugin plugin:testing-library/angular & plugin:jest-dom/recommended are removed
2 participants
@the-ult @timdeschryver