Skip to content

Use npm instead of Yarn #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Use npm instead of Yarn #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ job_defaults: &job_defaults
- image: circleci/node:12.9.1
working_directory: ~/project/repo

cache_key: &cache_key angular-testing-library-deps-cache-{{ checksum "yarn.lock" }}
cache_key: &cache_key angular-testing-library-deps-cache
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason of the lockfile was to cache.
I think that with this change, we should also remove cache_key and the cache usage for the CI?
That being said, I was considering to move to GH Actions, so perhaps now would be the perfect time...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know the optimal way to handle this with Circle, so feel free to make changes if you want. Or you can switch to Actions and I'll update this PR to use it instead.


jobs:
install:
Expand All @@ -16,7 +16,7 @@ jobs:
key: *cache_key
- run:
name: install-dependencies
command: yarn --frozen-lockfile --non-interactive
command: npm install
- save_cache:
key: *cache_key
paths:
Expand All @@ -30,7 +30,7 @@ jobs:
key: *cache_key
- run:
name: lint
command: yarn affected:lint
command: npm run affected:lint

build:
<<: *job_defaults
Expand All @@ -40,7 +40,7 @@ jobs:
key: *cache_key
- run:
name: build
command: yarn build --skip-nx-cache
command: npm run build --skip-nx-cache
- store_artifacts:
path: dist
- persist_to_workspace:
Expand All @@ -56,7 +56,7 @@ jobs:
key: *cache_key
- run:
name: test
command: yarn affected:test --ci --code-coverage
command: npm run affected:test --ci --code-coverage

release:
<<: *job_defaults
Expand All @@ -68,7 +68,7 @@ jobs:
at: dist
- run:
name: release
command: yarn semantic-release || true
command: npm run semantic-release || true

release-beta:
<<: *job_defaults
Expand All @@ -80,7 +80,7 @@ jobs:
at: dist
- run:
name: release
command: yarn semantic-release || true
command: npm run semantic-release || true

workflows:
version: 2
Expand Down
3 changes: 2 additions & 1 deletion .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
registry=http://registry.npmjs.org/
registry=http://registry.npmjs.org/
package-lock=false
Loading