Skip to content

Reduce peer dependencies for easier integration #333

Closed
@shaman-apprentice

Description

@shaman-apprentice

As a developer I want an easy integration into my project.

I am currently working on a project, which has some legacy dependencies which require rxjs@6 as peer dependency and their update would be quite some work.

This (awesome :) ) testing-library has rxjs@7 as peer dependency declared here.

This makes the dependency tree of the project invalid when integrating this testing library. I know that I can install nevertheless with --legacy-peer-deps but this looks like an awful error source to me.

Would it be feasible for you to integrate rxjs@7 as dev dependency? I see no hard downside in it? If you could also release it within @testing-library/angular@11 for Angular 13 support, that would be awesome for me.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions