Skip to content

glue: disable connection type and properties checks #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 3, 2024
Merged

glue: disable connection type and properties checks #759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76fd24f
glue: disable connection type and properties checks
bendrucker Nov 22, 2024
90f7e37
go generate
bendrucker Nov 22, 2024
d393e1a
rm unused rule
bendrucker Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/rules/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,7 +685,6 @@ These rules enforce best practices and naming conventions:
|aws_glue_catalog_table_invalid_table_type|✔|
|aws_glue_catalog_table_invalid_view_expanded_text|✔|
|aws_glue_catalog_table_invalid_view_original_text|✔|
|aws_glue_connection_invalid_connection_type|✔|
|aws_glue_crawler_invalid_security_configuration|✔|
|aws_glue_crawler_invalid_table_prefix|✔|
|aws_glue_dev_endpoint_invalid_role_arn|✔|
Expand Down
103 changes: 0 additions & 103 deletions rules/models/aws_glue_connection_invalid_connection_type.go
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions rules/models/mappings/glue.hcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ mapping "aws_glue_classifier" {

mapping "aws_glue_connection" {
catalog_id = any // CatalogIdString
connection_properties = ConnectionProperties
connection_type = ConnectionType
connection_properties = any // ConnectionProperties
connection_type = any // ConnectionType
description = any // DescriptionString
match_criteria = MatchCriteria
name = any // NameString
Expand Down
1 change: 0 additions & 1 deletion rules/models/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,6 @@ var Rules = []tflint.Rule{
NewAwsGlueCatalogTableInvalidTableTypeRule(),
NewAwsGlueCatalogTableInvalidViewExpandedTextRule(),
NewAwsGlueCatalogTableInvalidViewOriginalTextRule(),
NewAwsGlueConnectionInvalidConnectionTypeRule(),
NewAwsGlueCrawlerInvalidSecurityConfigurationRule(),
NewAwsGlueCrawlerInvalidTablePrefixRule(),
NewAwsGlueDevEndpointInvalidRoleArnRule(),
Expand Down
Loading