Add support for spot instances

[antonbabenko]

Follow up to #4

To-do:

• Add separate example which runs spot-instance. Keep existing as it was (revert your change).
• Update defaults specified in variables.tf, so that by default this module created on-demand instances (as before)
• Review all configurable parameters. Now not all of them are in variables.tf (eg, wait_for_fulfillment)
• "Thank you" goes to @johnypony3 :)

@johnypony3 Can you fix these?

[johnypony3]

awesome, im new to the module work for this product, given that the resources differ between a on-demand and spot instance (ec2 vs aws_spot_instance_request), im not sure if this approach will work. please correct me if im wrong.

[Vad1mo]

hello, what is the status of the MR? Can it be merged or does it need more rework?

[antonbabenko]

There are still the same actions to do as listed in the description.

[anhcuong]

please support spot instance !!!

[danihodovic]

Awesome!

[FernandoMiguel]

was this abandoned?

[antonbabenko]

@FernandoMiguel It is not entirely abandoned but there are still issues which should be resolved by somebody before merge.

[FernandoMiguel]

Thanks.
I'll fork this and test it.
Definitely need spot.
Thanks for the quick reply

[gluzangi]

When can this feature be merged? It's almost over half a year and think will be super useful to implement it as a part of the module

[meyerbro]

+1 on this one... We should build a new module then... Maybe fork the https://github.com/johnypony3/terraform-aws-ec2-spot-instance and use it on this official ORG with some small changes?

[Sebor]

Hello! Any news about that MR?

[antonbabenko]

At the very least, this PR should be updated/rebased to be compatible with Terraform 0.12/0.13+. If anyone wants to finish it, you are welcome!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.