Skip to content

feat: Add support for disable_api_stop attribute #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

msharma24
Copy link
Contributor

Description

Added disable_api_stop action attribute to the ec2 instance resource - Supported in latest TF Provider release 4.20.0

Motivation and Context

To prevent your instance from being accidentally stopped, you can enable stop protection for the instance.

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)

  • I have tested and validated these changes using one or more of the provided examples/* projects

  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs changed the title Feat/add disable api stop feat: Add support for disable_api_stop attribute Jun 29, 2022
@bryantbiggs
Copy link
Member

bryantbiggs commented Jun 29, 2022

Looks good and almost there - just need to update the min supported provider version to 4.20 and update the wrappers (will autoupdate if you install hcledit and run pre-commit)

@msharma24
Copy link
Contributor Author

@bryantbiggs Thanks . I have updated the versions.tf and wrappers/main.tf with pre-commit run -a

@msharma24
Copy link
Contributor Author

@bryantbiggs looks good ?

@bryantbiggs
Copy link
Member

you have a failing CI check - you need to run pre-commit run -a

@msharma24
Copy link
Contributor Author

@bryantbiggs 👍

pre-commit run -a
Terraform fmt............................................................Passed
Terraform wrapper with for_each in module................................Passed
Terraform validate.......................................................Passed
Terraform docs...........................................................Passed
Terraform validate with tflint...........................................Passed
check for merge conflicts................................................Passed
fix end of files.........................................................Passed

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @msharma24 !

@bryantbiggs bryantbiggs merged commit cb367ec into terraform-aws-modules:master Jul 19, 2022
antonbabenko pushed a commit that referenced this pull request Jul 19, 2022
## [4.1.0](v4.0.0...v4.1.0) (2022-07-19)

### Features

* Add support for `disable_api_stop` attribute ([#275](#275)) ([cb367ec](cb367ec))
@antonbabenko
Copy link
Member

This PR is included in version 4.1.0 🎉

@msharma24 msharma24 deleted the feat/add_disable_api_stop branch July 19, 2022 13:02
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants