conn: create from socket fd #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askalt
force-pushed
the
askalt/gh-304-socket-fd-connection
branch
6 times, most recently
from
f033280 to
df0eec0
Compare
askalt
force-pushed
the
askalt/gh-304-socket-fd-connection
branch
from
df0eec0 to
5b9f1cc
Compare
oleg-jukovec
reviewed
Nov 1, 2023
askalt
force-pushed
the
askalt/gh-304-socket-fd-connection
branch
12 times, most recently
from
c77681b to
8aaece6
Compare
|
There will be one more test (with Tarantool made sockets and child process), but in general it is already ready for the review. |
oleg-jukovec
reviewed
Nov 2, 2023
askalt
force-pushed
the
askalt/gh-304-socket-fd-connection
branch
2 times, most recently
from
7d6454e to
39815c1
Compare
oleg-jukovec
reviewed
Nov 3, 2023
oleg-jukovec
reviewed
Nov 3, 2023
oleg-jukovec
requested changes
Nov 3, 2023
askalt
force-pushed
the
askalt/gh-304-socket-fd-connection
branch
from
39815c1 to
02d7bc2
Compare
oleg-jukovec
reviewed
Nov 3, 2023
askalt
force-pushed
the
askalt/gh-304-socket-fd-connection
branch
from
02d7bc2 to
5712143
Compare
askalt
force-pushed
the
askalt/gh-304-socket-fd-connection
branch
from
5712143 to
6b00156
Compare
oleg-jukovec
approved these changes
Nov 4, 2023
askalt
force-pushed
the
askalt/gh-304-socket-fd-connection
branch
5 times, most recently
from
d470f82 to
42e7f85
Compare
askalt
force-pushed
the
askalt/gh-304-socket-fd-connection
branch
2 times, most recently
from
195b3c9 to
543e17d
Compare
DifferentialOrange
approved these changes
Nov 10, 2023
tarantool/connection.py
Outdated
Comment on lines
818
to
820
| raise ConfigurationError("need to specify both host and port, " | ||
| "port only in the case on Unix sockets, " | ||
| "or socket_fd in the case of socket fd") |
There was a problem hiding this comment.
Suggested change
| raise ConfigurationError("need to specify both host and port, " | |
| "port only in the case on Unix sockets, " | |
| "or socket_fd in the case of socket fd") | |
| raise ConfigurationError("need to specify host/port, " | |
| "port (in case of Unix sockets)" | |
| "or socket_fd") |
This patch adds the ability to create Tarantool connection using an existing socket fd. To achieve this, several changes have been made to work with non-blocking sockets, as `socket.socketpair` creates such [1]. The authentication [2] might have already occured when we establish such a connection. If that's the case, there is no need to pass 'user' argument. On success, connect takes ownership of the `socket_fd`. 1. tarantool/tarantool#8944 2. https://www.tarantool.io/en/doc/latest/dev_guide/internals/iproto/authentication/ Closes #304
askalt
force-pushed
the
askalt/gh-304-socket-fd-connection
branch
from
543e17d to
8da5df2
Compare
DifferentialOrange
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the ability to create Tarantool connection using an existing socket fd.
I didn't forget about:
Closes #304