datetime: support big values for some platforms #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DifferentialOrange
force-pushed
the
DifferentialOrange/big-datetime
branch
from
6c60382 to
8d3427c
Compare
oleg-jukovec
approved these changes
Sep 19, 2023
DifferentialOrange
changed the base branch from
DifferentialOrange/crud-error-rethrow
to
master
DifferentialOrange
force-pushed
the
DifferentialOrange/big-datetime
branch
2 times, most recently
from
ae9ea59 to
7b9abe2
Compare
Before this patch, tarantool.Datetime constructor used datetime.fromtimestamp function to build a new datetime [1], except for negative timestamps for Windows platform. This constructor branch is used on each Tarantool datetime encoding or while building a tarantool.Datetime object from timestamp. datetime.fromtimestamp have some drawbacks: it "may raise OverflowError, if the timestamp is out of the range of values supported by the platform C localtime() or gmtime() functions, and OSError on localtime() or gmtime() failure. It’s common for this to be restricted to years in 1970 through 2038.". It had never happened on supported Unix platforms, but seem to be an issue for Windows ones. We already workaround this issue for years smaller than 1970 on Windows. After this patch, this workaround will be used for all platforms and timestamp values, allowing to provide similar behavior for platforms both restricted to years in 1970 through 2038 with localtime() or gmtime() or not. 1. https://docs.python.org/3/library/datetime.html#datetime.datetime.fromtimestamp
DifferentialOrange
force-pushed
the
DifferentialOrange/big-datetime
branch
from
7b9abe2 to
0f7f91b
Compare
DifferentialOrange
added a commit
that referenced
this pull request
Sep 20, 2023
Overview This release introduce several bugfixes and behavior improvements. Fixed - Exception rethrow in crud API (PR #310). - Work with timestamps larger than year 2038 for some platforms (like Windows) (PR #311). It covers - building new `tarantool.Datetime` objects from timestamp, - parsing datetime objects received from Tarantool.
Merged
DifferentialOrange
added a commit
that referenced
this pull request
Sep 20, 2023
Overview This release introduce several bugfixes and behavior improvements. Fixed - Exception rethrow in crud API (PR #310). - Work with timestamps larger than year 2038 for some platforms (like Windows) (PR #311). It covers - building new `tarantool.Datetime` objects from timestamp, - parsing datetime objects received from Tarantool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, tarantool.Datetime constructor used datetime.fromtimestamp function to build a new datetime [1], except for negative timestamps for Windows platform. This constructor branch is used on each Tarantool datetime encoding or while building a tarantool.Datetime object from timestamp. datetime.fromtimestamp have some drawbacks: it "may raise OverflowError, if the timestamp is out of the range of values supported by the platform C localtime() or gmtime() functions, and OSError on localtime() or gmtime() failure. It’s common for this to be restricted to years in 1970 through 2038.". It had never happened on supported Unix platforms, but seem to be an issue for Windows ones. We already workaround this issue for years smaller than 1970 on Windows. After this patch, this workaround will be used for all platforms and timestamp values, allowing to provide similar behavior for platforms both restricted to years in 1970 through 2038 with localtime() or gmtime() or not.