iproto: disable feature discovery for specific versions #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegrok
force-pushed
the
283-iproto-features-bug
branch
from
22a617c to
582016f
Compare
olegrok
force-pushed
the
283-iproto-features-bug
branch
from
582016f to
7541aa0
Compare
Yes. Fixed.
If you don't have any plans to add new features then yes. Otherwise I could wait some time. |
It seems that there is a bug issue which could also be fixed relatively quickly, so I'll release after we'll work through #282 too. But |
"IProto features" are available since Tarantool 2.10 and there is no need to even try to fetch them for lower versions. Such check there is in netbox code [1]. Before this patch cartridge remote control closed the connection after RequestProtocolVersion however but for netbox it worked fine. So let's uniform behaviour between connectors adding a small check to skip request if there is a gurarntee that "IProto features" are not supported. Closes tarantool#283 [1] tarantool/tarantool@2cbec82#diff-a47383908beda20a06c9f64bf5c3d4c51879034e38bcdccdf45210e89ce6dfb7R1947
olegrok
force-pushed
the
283-iproto-features-bug
branch
from
7541aa0 to
cd72939
Compare
DifferentialOrange
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"IProto features" are available since Tarantool 2.10 and there is no need to even try to fetch them for lower versions. Such check there is in netbox code [1].
Before this patch cartridge remote control closed the connection after RequestProtocolVersion however but for netbox it worked fine.
So let's uniform behaviour between connectors adding a small check to skip request if there is a gurarntee that "IProto features" are not supported.
Closes #283
[1] tarantool/tarantool@2cbec82#diff-a47383908beda20a06c9f64bf5c3d4c51879034e38bcdccdf45210e89ce6dfb7R1947