New msgpack extensions, extended connection options, bug fixes #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Now supports 3 new msgpack extensions: UUID, Datetime, Decimal - Connection object accepts all options of net.createConnection() - Extended readme documentation
- Updated Readme docs - New nonWritableHostPolicy and related options, which improves a high availability capability without any 3rd parties - Ability to disable the offline queue - Now Unix-sockets can be passed as string in first argument of connection constructor and recognized correcty
Fixed 'nonWritableHostPolicy' option description.
Beautified options
|
Sorry, but |
|
Will inspect this. What is the reason to use the Denque? The whole functionality of this module could be implemented with a native Array's methods like push / pop / shift / splice, which are 2 times faster in my own benchmarks and available since node 0.10.0 version |
- Fixed compatability with old versions of Node.JS - Little fix of 'test' suite in order to pass it with new Unix socket support - selectCb() parameters now can accept spaceId and indexId as Strings, not only numbers
Renamed to 'msgpack-extensions' for clarity
Fixed it |
goodwise
changed the title
Closed
- Some performance improvements by caching internal values. - TLS (SSL) support. - New `pipeline()`+`exec()` methods kindly borrowed from the [ioredis](https://github.com/redis/ioredis?tab=readme-ov-file#pipelining), which lets you to queue some commands in memory and then send them simultaneously to the server in a single (or several, if request body is too big) network call(s). Thanks to the Tarantool, which [made this possible](https://www.tarantool.io/en/doc/latest/dev_guide/internals/iproto/format/#packet-structure). This way the performance is significantly improved by 500-1600% - you can check it by yourself running `npm run benchmark-read` or `npm run benchmark-write`. Note that this feature doesn't replaces the Transaction model, which has some level of isolation. - Changed `const` declaration to `var` in order to support old Node.JS versions.
|
@sergos @oleg-jukovec any news? |
Use `.findPipelineError(pipeline_answer)` to get the first error and `.findPipelineErrors()` to get an array of all occured errors.
filonenko-mikhail
approved these changes
Sep 5, 2024
As of today tests are passing, no more questions from me. |
Co-authored-by: Michael Filonenko <filonenko.mikhail@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
net.createConnection(), including Unix socket path.nonWritableHostPolicyand related options, which improves a high availability capabilities without any 3rd parties.packInteger()to solve this.selectCb()now also acceptsspaceIdandindexIdas their String names, not only their IDs.pipeline()+exec()methods kindly borrowed from the ioredis, which lets you to queue some commands in memory and then send them simultaneously to the server in a single (or several, if request body is too big) network call(s). Thanks to the Tarantool, which made this possible.This way the performance is significantly improved by 500-1600% - you can check it yourself by running
npm run benchmark-readornpm run benchmark-write.Note that this feature doesn't replaces the Transaction model, which has some level of isolation.
constdeclaration tovarin order to support old Node.JS versions.