pool: fix notify on remove a connection #385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConnectionPool.Remove() does not notify a ConnectionHandler on an instance removing from the pool.
oleg-jukovec
force-pushed
the
oleg-jukovec/pool-remove-does-not-call-deactivated
branch
from
677532a to
ebb4c08
Compare
oleg-jukovec
requested review from
better0fdead
and removed request for
psergee
DerekBum
approved these changes
Feb 29, 2024
better0fdead
approved these changes
Feb 29, 2024
oleg-jukovec
deleted the
oleg-jukovec/pool-remove-does-not-call-deactivated
branch
oleg-jukovec
added a commit
that referenced
this pull request
Mar 6, 2024
Overview
The small release improves the ConnectionPool. The ConnectionPool
is no longer required execute access for `box.info` from a user
for Tarantool >= 3.0.0.
Breaking changes
There are no breaking changes in the release.
New features
`execute` access for `box.info` is no longer required for
ConnectionPool for a Tarantool version >= 3.0.0 (#380).
Bugfixes
`ConnectionPool.Remove()` does not notify a `ConnectionHandler`
after an instance is already removed from the pool (#385).
Merged
oleg-jukovec
added a commit
that referenced
this pull request
Mar 6, 2024
Overview
The small release improves the ConnectionPool. The ConnectionPool
is no longer required execute access for `box.info` from a user
for Tarantool >= 3.0.0.
Breaking changes
There are no breaking changes in the release.
New features
`execute` access for `box.info` is no longer required for
ConnectionPool for a Tarantool version >= 3.0.0 (#380).
Bugfixes
`ConnectionPool.Remove()` does not notify a `ConnectionHandler`
after an instance is already removed from the pool (#385).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConnectionPool.Remove() does not notify a ConnectionHandler on an instance removing from the pool.
I didn't forget about (remove if it is not applicable):