api: mark all request methods as deprecated #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-241-deprecated
branch
2 times, most recently
from
6e60886 to
1ce37ff
Compare
DifferentialOrange
approved these changes
Jun 16, 2023
We mark all request methods as deprecated because the logic based on request methods is very difficult to extend. These methods will be removed in a next major version. The client code should prefer a request object + Do(). We have updated all examples for this purpose. Closes #241
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-241-deprecated
branch
from
1ce37ff to
09696a3
Compare
GRISHNOV
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We mark all request methods as deprecated because the logic based on request methods is very difficult to extend. These methods will be removed in a next major version.
The client code should prefer a request object + Do(). We have updated all examples for this purpose.
I didn't forget about (remove if it is not applicable):
Related issues:
Closes #241