datetime: sync datetime range with Tarantool #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-191-fix-datetime-range
branch
2 times, most recently
from
f4c64a0 to
0810763
Compare
|
You could to build a Tarantool from the branch to play with tests: https://github.com/tsafin/tarantool/tree/tsafin/gh-6723-mp-unpack-datetime |
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-191-fix-datetime-range
branch
from
0810763 to
acdc47c
Compare
ligurio
approved these changes
Jul 1, 2022
The patch adds check for supported Datetime values. The supported range comes from Tarantool implementation [1] and c-dt library [2]. 1. https://github.com/tarantool/tarantool/blob/a99ccce5f517d2a04670289d3d09a8cc2f5916f9/src/lib/core/datetime.h#L44-L61 2. https://github.com/tarantool/c-dt/blob/e6214325fe8d4336464ebae859ac2b456fd22b77/API.pod#introduction Closes #191
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-191-fix-datetime-range
branch
from
acdc47c to
9765cd4
Compare
AnaNek
approved these changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch adds check for supported Datetime values. The supported range
comes from Tarantool implementation [1] and c-dt library [2].
I didn't forget about (remove if it is not applicable):
I didn't add an entry to CHANGELOG.md because there hasn't been a release since datetime support. But I can add if necessary.
Related issues:
Closes #191