Skip to content

UUID submodule dependency is broken #134

Closed
@DifferentialOrange

Description

@DifferentialOrange

Reproducer:

package main

import (
	_ "github.com/tarantool/go-tarantool"
	_ "github.com/tarantool/go-tarantool/uuid"
)
go mod tidy
github.com/tarantool/go-tarantool v0.0.0-20211104105631-61f3a41907b6/go.mod h1:m/mppmrDtgvS3tqUvaZRdRtlgzK1Gz/T6uGndkOItmQ=
github.com/tarantool/go-tarantool v0.0.0-20220113162241-9c9a68e09870 h1:oVoH+fRulel/M1XIbYlhO2tAiLXK1FT+GQQwfMkkDqM=
github.com/tarantool/go-tarantool v0.0.0-20220113162241-9c9a68e09870/go.mod h1:J//scltxiWkCB+p3u0w1cMoyiMIV1p0bttckvHY1qnQ=
github.com/tarantool/go-tarantool/uuid v0.0.0-20220113162241-9c9a68e09870 h1:z2zfPmgIKsEojgVaULH1su9PNJGn+k/NwFGjVtkVqhc=
github.com/tarantool/go-tarantool/uuid v0.0.0-20220113162241-9c9a68e09870/go.mod h1:yDmq7heOcE3N/ZlpCXxUUpluM7frb6+g6ugo7apYVtE=

Since go-tarantool/uuid is a separate submodule (see #104 comments) and it requires original module to run tests, it uses github.com/tarantool/go-tarantool as a dependency. And them we have problems:

  1. when I install go-tarantool+uuid, my application has two go-tarantool dependencies;
  2. when I change something in main module, I cannot use it in submodule test since it points to some github master (and moving a pointer to a branch would not be a good solution either).

The only way I see now is to completely remove uuid_test.go, which isn't a good one.

Metadata

Metadata

Labels

bugSomething isn't workingcode healthImprove code readability, simplify maintenance and so onhelp wantedExtra attention is needed

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions