Skip to content

Update net.box options #2912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jun 14, 2022
Merged

Update net.box options #2912

merged 13 commits into from
Jun 14, 2022

Conversation

rindblack15
Copy link
Contributor

@rindblack15 rindblack15 commented Jun 2, 2022 •
edited
Loading

Closes #2418
Fixes #2910

@rindblack15 rindblack15 self-assigned this Jun 2, 2022
@github-actions github-actions bot temporarily deployed to branch-gh-2418-updating_the_net_box_options June 2, 2022 07:02 Inactive
@rindblack15 rindblack15 linked an issue Jun 2, 2022 that may be closed by this pull request
Document required_protocol_version/features net.box options #2418
Closed
@rindblack15 rindblack15 requested a review from locker June 2, 2022 07:27
@github-actions github-actions bot temporarily deployed to branch-gh-2418-updating_the_net_box_options June 2, 2022 08:04 Inactive
@github-actions github-actions bot temporarily deployed to branch-gh-2418-updating_the_net_box_options June 2, 2022 08:29 Inactive
locker
locker requested changes Jun 2, 2022
View reviewed changes
@github-actions github-actions bot temporarily deployed to branch-gh-2418-updating_the_net_box_options June 2, 2022 11:00 Inactive
@github-actions github-actions bot temporarily deployed to branch-gh-2418-updating_the_net_box_options June 2, 2022 11:58 Inactive
@rindblack15 rindblack15 requested a review from locker June 2, 2022 12:07
@github-actions github-actions bot temporarily deployed to branch-gh-2418-updating_the_net_box_options June 3, 2022 08:30 Inactive
@rindblack15 rindblack15 requested a review from patiencedaur June 3, 2022 08:44
patiencedaur
patiencedaur suggested changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@patiencedaur patiencedaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kudos for the updated example! :)

However, the order in which all this content is presented now is not quite convenient. For now, some information is repeated twice, and for some reason, the summary is below the details. Let's reshuffle the structure and put it like this:

net_box.connect(URI[, {options}])
For options, please see the net_box.new() description below.

net_box.new(URI[, {options}])
Parameters: ...
Return: ...
Return type: ...
Possible options: (here goes the new fragment and the table)
Examples: ...

Please reach out if anything's unclear.

@github-actions github-actions bot temporarily deployed to branch-gh-2418-updating_the_net_box_options June 3, 2022 10:08 Inactive
@github-actions github-actions bot temporarily deployed to branch-gh-2418-updating_the_net_box_options June 3, 2022 10:20 Inactive
@github-actions github-actions bot temporarily deployed to branch-gh-2418-updating_the_net_box_options June 3, 2022 10:33 Inactive
@github-actions github-actions bot temporarily deployed to branch-gh-2418-updating_the_net_box_options June 6, 2022 02:49 Inactive
@github-actions github-actions bot temporarily deployed to branch-gh-2418-updating_the_net_box_options June 6, 2022 03:19 Inactive
@rindblack15 rindblack15 requested a review from veod32 June 6, 2022 03:34
veod32
veod32 requested changes Jun 7, 2022
View reviewed changes
@github-actions github-actions bot temporarily deployed to branch-gh-2418-updating_the_net_box_options June 8, 2022 10:02 Inactive
@github-actions github-actions bot temporarily deployed to branch-gh-2418-updating_the_net_box_options June 9, 2022 04:19 Inactive
@rindblack15 rindblack15 requested a review from veod32 June 9, 2022 04:27
@github-actions github-actions bot temporarily deployed to branch-gh-2418-updating_the_net_box_options June 9, 2022 04:45 Inactive
veod32
veod32 reviewed Jun 10, 2022
View reviewed changes
@github-actions github-actions bot temporarily deployed to branch-gh-2418-updating_the_net_box_options June 10, 2022 13:08 Inactive
@github-actions github-actions bot temporarily deployed to branch-gh-2418-updating_the_net_box_options June 10, 2022 13:30 Inactive
@rindblack15 rindblack15 marked this pull request as ready for review June 10, 2022 13:39
@rindblack15 rindblack15 requested a review from patiencedaur June 10, 2022 13:40
@rindblack15 rindblack15 merged commit c643908 into latest Jun 14, 2022
@rindblack15 rindblack15 deleted the rindblack15/gh-2418-updating_the_net_box_options branch June 14, 2022 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veod32 veod32 veod32 approved these changes

@locker locker locker approved these changes

@patiencedaur patiencedaur patiencedaur approved these changes

Assignees

@rindblack15 rindblack15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feedback: Module net.box | Tarantool Document required_protocol_version/features net.box options
4 participants
@rindblack15 @locker @patiencedaur @veod32