Skip to content

Use bitmap subscr #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 13, 2019
Merged

Conversation

siehputz
Copy link

Added code in bmp/indexed.py to swap the red and green bytes. Also added a color whell image to images and an example script to load it.

Copy link
Owner

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you need help with lint. It can be pretty picky.

palette[value] = bytes(b''.join([c_bytes[2:3],
c_bytes[1:2],
c_bytes[0:1],
c_bytes[3:1]]))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

faster?

            palette[value] = bytes([c_bytes[2], c_bytes[1], c_bytes[0], c_bytes[3]]) 

Copy link
Owner

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @DavePutz and @siehputz! We can address any further comments with new PRs.

@tannewt tannewt merged commit 7cf463d into tannewt:use_bitmap_subscr May 13, 2019
tannewt pushed a commit that referenced this pull request May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants