Fix infinite scrollToBottom method #390
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of this PR? (check at least one)
Other information:
In certain condition, the method
scrollToBottom
stuck in infinite loop due to this recursive statement.The condition for checking whether scroll is at bottom or not equals to below.
It works usually, but in case that clientHeight is non-integer value, there can be a problem.
Since user agents round those values(in my case, Chrome), sum of scrollTop and clientHeight can be 1px smaller than scrollHeight, though scroll is at bottom.
For example, this was my case.
I'm not sure how scrollTop value is calculated internally, but tiny change can fix the problem. (https://stackoverflow.com/a/32283147)