Skip to content

Suggest lighter css rule #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

sachinraja
Copy link

@sachinraja sachinraja commented Jun 17, 2021

css.validate disables all css linting. This rule only disables linting for the unknown @ rules like @tailwind.

`css.validate` disables all css linting. This rule only disables the unknown `@` rules like `@tailwind` and `@apply`.
@bradlc
Copy link
Contributor

bradlc commented Jul 7, 2021

Interesting! I swear at some point there was a built-in rule that caused an error when you had something like this:

.example {
  @apply one two;
}

You would get an error like "expected semi-colon after one", and the only way to disable that one was to disable css.validate completely. But it seems like this error doesn't happen anymore (or I imagined it), so I think this change is good 🤔

@sachinraja
Copy link
Author

I believe I was getting the same error, but it just mysteriously disappeared. The only thing I can find is this PR, but it's from 2016.

@bradlc
Copy link
Contributor

bradlc commented Feb 21, 2022

Hey @sachinraja. For now we're going to leave it as it is, because there's other situations where you get lint errors if css.validate is true, for example when using the screen function:

@media screen(sm) {}

Thank you for the suggestion though!

@bradlc bradlc closed this Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants