Fix widgets not updating with parent's widget #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Jan 19, 2025
jserv
reviewed
Jan 19, 2025
|
The issue that this pull request aims to solve cannot always reproduce successfully. Therefore, I record it. |
|
I also recorded the display after the code applied the modification of this pull request. |
Implement the twin_widget_children_paint function to repaint all the box's widgets. The issue arises when the spline updates the pixmap beneath the button widget, the pixmap of the button isn't triggered to repaint. To solve this, we call the twin_widget_paint function after the spline update to ensure the related widget will be repainted. Signed-off-by: Wei-Hsin Yeh <weihsinyeh168@gmail.com>
The global redisplay thread would block on a semaphore, which is signaled by the per-window redisplay threads whenever the content of any window changes. For example, the per-window redisplay thread is triggered when its content twin_box_t is triggered by the event TwinEventButtonDown. In this case, the corresponding window should also be marked as active. To ensure proper display, we added the function twin_window_show to indirectly update the damaged screen. Signed-off-by: Wei-Hsin Yeh <weihsinyeh168@gmail.com>
weihsinyeh
force-pushed
the
screen_update
branch
from
60132b4 to
56bc784
Compare
|
Thank @weihsinyeh for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the twin_widget_children_paint function to repaint all the box's widgets. The issue arises when the spline updates the pixmap beneath the button widget, the pixmap of the button isn't triggered to repaint. To solve this, we call the twin_widget_paint function after the spline update to ensure the related widget will be repainted.