-
-
Notifications
You must be signed in to change notification settings - Fork 3
Add JSX support in type definition #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
73d2f25
Add JSX support in type definition
remcohaszing e59a664
Merge branch 'main' into jsx-types
remcohaszing 15f0f17
Revert unrelated change
remcohaszing 90d9256
Finish unfinished sentence in jsdoc
remcohaszing 36efe3b
Use namespace imports to import xastscript in TypeScript
remcohaszing dbe6ead
Document usage of JSX with TypeScript
remcohaszing b2d187a
Fix jsx Element type assertions
remcohaszing 7ccd65a
Update types/index.d.ts
remcohaszing 0eb0d4f
Add link to TypeScript JSX documentation
remcohaszing de3f530
Add support for Fragments
remcohaszing c24b837
Change type of ElementChildrenAttribute[children] to never
remcohaszing File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
import {Element, Root} from 'xast' | ||
import * as x from 'xastscript' | ||
|
||
const xmlns = 'http://www.sitemaps.org/schemas/sitemap/0.9' | ||
|
||
let jsx: Element | Root | ||
jsx = <urlset /> | ||
jsx = <urlset xmlns={xmlns} /> | ||
jsx = <urlset>string</urlset> | ||
jsx = <urlset>{['string', 'string']}</urlset> | ||
jsx = ( | ||
<urlset xmlns={xmlns}> | ||
<child /> | ||
</urlset> | ||
) | ||
jsx = ( | ||
<urlset> | ||
<loc /> | ||
string | ||
</urlset> | ||
) | ||
jsx = ( | ||
<urlset> | ||
<loc /> | ||
</urlset> | ||
) | ||
jsx = ( | ||
<urlset> | ||
<loc /> | ||
<loc /> | ||
</urlset> | ||
) | ||
jsx = <urlset>{[<loc />, <loc />]}</urlset> | ||
jsx = <urlset>{[]}</urlset> | ||
jsx = <></> | ||
|
||
jsx = <foo invalid={{}}></foo> // $ExpectError | ||
jsx = <foo>{{invalid: 'child'}}</foo> // $ExpectError | ||
|
||
const element: Element = <foo /> // $ExpectError | ||
const root: Root = <></> // $ExpectError | ||
|
||
declare function Bar(props?: Record<string, unknown>): Element | ||
const bar = <Bar /> // $ExpectError |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.