End offset for text containing entities is incorrect

[siefkenj]

Initial checklist

• I read the support docs
• I read the contributing guide
• I agree to follow the code of conduct
• I searched issues and couldn’t find anything (or linked relevant results below)

Affected packages and versions

2.0.1

Link to runnable example

No response

Steps to reproduce

Exectue fromXml("<foo>text&amp;text</foo>")

Expected behavior

The offset position should start at 5 and end at 18

Actual behavior

The offset position should start at 5 and end at 15

Affected runtime and version

node@18.12.1

Affected package manager and version

No response

Affected OS and version

No response

Build and bundle tools

No response

[wooorm]

Hmm, the positional info of sax isn’t very good.
I’m not a giant fan of sax, it’s very loose, pretty big.

I think I’d like to switch to something else. Perhaps https://github.com/rgrove/parse-xml. Seems fast. Halve the size. Well-maintained and modern. Doesn’t expose positional info from what I can see though

[siefkenj]

Another parser is probably a good idea. I encountered this error when working on a converter from lezer-xml to xast.

I have it basically working: https://github.com/siefkenj/typescript-xml/tree/main/packages/xml/src/lezer/lezer-to-xast

The only differences between fromXml and what I just made are correct positions and no errors (lezer is designed to parse no matter what, though it can be instructed to throw on the first error).

[github-actions]

Hi! This was closed. Team: If this was fixed, please add phase/solved. Otherwise, please add one of the no/* labels.