Skip to content

Add types #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 2, 2019
Merged

Add types #9

merged 7 commits into from
Nov 2, 2019

Conversation

shanehandley
Copy link
Contributor

Adds typings according to the format from unist-builder

See #8 (comment)

Closes #8

@wooorm
Copy link
Member

wooorm commented Oct 31, 2019

/cc @Rokt33r and @ChristianMurphy!

@wooorm wooorm changed the title Feature/typings Add types Oct 31, 2019
@wooorm wooorm added ☂️ area/types This affects typings 🙆 yes/confirmed This is confirmed and ready to be worked on 🦋 type/enhancement This is great to have 🧑 semver/major This is a change labels Oct 31, 2019
ChristianMurphy
ChristianMurphy requested changes Oct 31, 2019
View reviewed changes
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shanehandley!
Added a few comments below.

shanehandley and others added 5 commits November 1, 2019 14:34
@shanehandley @ChristianMurphy
Fix types reference
8ac93bc 
Co-Authored-By: Christian Murphy <christian.murphy.42@gmail.com>
@shanehandley @ChristianMurphy
Add types to package.json
58e29bc 
Co-Authored-By: Christian Murphy <christian.murphy.42@gmail.com>
@shanehandley @ChristianMurphy
JSON: dangling comma
ec31a99 
Co-Authored-By: Christian Murphy <christian.murphy.42@gmail.com>
@shanehandley @ChristianMurphy
Fix dtslint reference
af5fa94 
Co-Authored-By: Christian Murphy <christian.murphy.42@gmail.com>
@shanehandley
Add dtslint, remove noise from typings that was required for Definite…
43fe767 
…lyTyped validation.
@shanehandley
Copy link
Contributor Author

Thanks @ChristianMurphy, sorry I rushed this initially. I've made the requested changes.

ChristianMurphy
ChristianMurphy approved these changes Nov 2, 2019
View reviewed changes
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @shanehandley! 🙇‍♂️

@wooorm wooorm merged commit 3c4d4a1 into syntax-tree:master Nov 2, 2019
@wooorm wooorm added ⛵️ status/released and removed 🙆 yes/confirmed This is confirmed and ready to be worked on labels Nov 3, 2019
@shanehandley shanehandley deleted the feature/typings branch November 3, 2019 02:53
@ChristianMurphy ChristianMurphy mentioned this pull request Feb 6, 2020
Closed
@wooorm wooorm added the 💪 phase/solved Post is done label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm approved these changes

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

Assignees
No one assigned
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done 🧑 semver/major This is a change 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typings
3 participants
@shanehandley @wooorm @ChristianMurphy