Skip to content

Add support for hiding positions #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2020
Merged

Add support for hiding positions #12

merged 1 commit into from
Apr 28, 2020

Conversation

wooorm
Copy link
Member

@wooorm wooorm commented Apr 25, 2020

Closes GH-10.

Touches on typescript, so /cc @ChristianMurphy. And /cc @shanehandley who wrote the types.

@wooorm wooorm added 🦋 type/enhancement This is great to have 🧒 semver/minor This is backwards-compatible change 🗄 area/interface This affects the public interface ☂️ area/types This affects typings 🙆 yes/confirmed This is confirmed and ready to be worked on labels Apr 25, 2020
@wooorm
Copy link
Member Author

wooorm commented Apr 25, 2020

Also: the option name (showPositions) is up for debate. This was used because show* is a prefix used by Node’s util.inspect.

@wooorm wooorm merged commit b7ab151 into master Apr 28, 2020
@wooorm wooorm deleted the show-positions branch April 28, 2020 07:20
@wooorm wooorm added ⛵️ status/released and removed 🙆 yes/confirmed This is confirmed and ready to be worked on labels Apr 28, 2020
@wooorm wooorm added the 💪 phase/solved Post is done label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

Assignees
No one assigned
Labels
🗄 area/interface This affects the public interface ☂️ area/types This affects typings 💪 phase/solved Post is done 🧒 semver/minor This is backwards-compatible change 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to turn off location information
2 participants
@wooorm @ChristianMurphy