Skip to content

Add types #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 30, 2020
Merged

Add types #5

merged 2 commits into from
Jul 30, 2020

Conversation

mrzmmr
Copy link
Contributor

@mrzmmr mrzmmr commented Jul 29, 2020

Adds types and tests copying what Roang-zero1 did for unist-util-find-all-after.

ChristianMurphy
ChristianMurphy approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrzmmr! 🙇

@ChristianMurphy ChristianMurphy requested a review from a team July 29, 2020 17:57
@ChristianMurphy ChristianMurphy added ☂️ area/types This affects typings 🦋 type/enhancement This is great to have 🧑 semver/major This is a change labels Jul 29, 2020
@mrzmmr @ChristianMurphy
Apply suggestions from code review
94e9d46 
Co-authored-by: Christian Murphy <christian.murphy.42@gmail.com>
@wooorm wooorm merged commit a252029 into syntax-tree:main Jul 30, 2020
@wooorm
Copy link
Member

wooorm commented Jul 30, 2020

Thanks @mrzmmr, released in 3.0.0!

@wooorm wooorm added the 💪 phase/solved Post is done label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm approved these changes

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

Assignees
No one assigned
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done 🧑 semver/major This is a change 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrzmmr @wooorm @ChristianMurphy