Skip to content

Add JSDoc based types #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2021
Merged

Add JSDoc based types #2

merged 2 commits into from
May 10, 2021

Conversation

wooorm
Copy link
Member

@wooorm wooorm commented Apr 19, 2021

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Add JSDoc based types


Notes

  • The check functions should allow unknown values; but typescript becomes really annoying when ducktyping whether something in fact looks like a certain node. Any ideas?
  • I’m messing up somewhere, I don’t know how to solve the “Assertions require every name in the call target to be declared with an explicit type annotation.” error.

@wooorm wooorm requested a review from ChristianMurphy April 19, 2021 09:58
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Apr 19, 2021
@wooorm wooorm added ☂️ area/types This affects typings 🙆 yes/confirmed This is confirmed and ready to be worked on 🧑 semver/major This is a change labels Apr 19, 2021
@wooorm wooorm marked this pull request as ready for review May 10, 2021 09:36
@wooorm wooorm changed the title wip: Add JSDoc based types Add JSDoc based types May 10, 2021
@wooorm wooorm merged commit 098866d into main May 10, 2021
@wooorm wooorm deleted the ts branch May 10, 2021 09:52
@github-actions

This comment has been minimized.

@wooorm wooorm added the 💪 phase/solved Post is done label May 10, 2021
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label May 10, 2021
@wooorm wooorm removed the 🙆 yes/confirmed This is confirmed and ready to be worked on label May 10, 2021
wooorm added a commit to unifiedjs/beep-boop-beta that referenced this pull request May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done 🧑 semver/major This is a change
Development

Successfully merging this pull request may close these issues.

1 participant