Skip to content

Add types #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 13, 2019
Merged

Add types #1

merged 3 commits into from
Nov 13, 2019

Conversation

ChristianMurphy
Copy link
Member

@ChristianMurphy ChristianMurphy commented Nov 4, 2019

This currently has two major blockers

Once those are resolved, this will need:

  • TSDocs
  • Type tests

@ChristianMurphy ChristianMurphy added 🦋 type/enhancement This is great to have help wanted 🙏 This could use your insight or help 🙉 open/needs-info This needs some more info 🧑 semver/major This is a change ☂️ area/types This affects typings 🌊 blocked/upstream This cannot progress before something external happens first 🛠 blocked/wip This cannot progress yet, it’s being worked on labels Nov 4, 2019
@ChristianMurphy
Copy link
Member Author

/cc @Rokt33r any ideas around how to work around void being reserved?

@Rokt33r
Copy link

Rokt33r commented Nov 6, 2019

@ChristianMurphy https://github.com/sindresorhus/filenamify/blob/master/index.d.ts
This should be the solution!

@ChristianMurphy ChristianMurphy removed help wanted 🙏 This could use your insight or help 🌊 blocked/upstream This cannot progress before something external happens first 🛠 blocked/wip This cannot progress yet, it’s being worked on labels Nov 12, 2019
@ChristianMurphy
Copy link
Member Author

Thanks @Rokt33r that resolved the issue.

@ChristianMurphy ChristianMurphy requested a review from a team November 12, 2019 21:54
@ChristianMurphy
Copy link
Member Author

Blockers have been resolved, this is now ready for review.

@ChristianMurphy
Copy link
Member Author

@wooorm note that this also includes a couple JS changes suggested by XO.

@ChristianMurphy ChristianMurphy added 🔍 status/open and removed 🙉 open/needs-info This needs some more info labels Nov 12, 2019
Copy link

@Rokt33r Rokt33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wooorm wooorm changed the title types: add typings to unist-util-assert Add types Nov 13, 2019
@wooorm wooorm merged commit 86d8534 into syntax-tree:master Nov 13, 2019
@ChristianMurphy ChristianMurphy deleted the types/add-typings branch November 13, 2019 15:56
@wooorm
Copy link
Member

wooorm commented Nov 13, 2019

I wanted to release this but rm -rf node_modules; npm i; npm t fails for me:

> unist-util-assert@1.0.4 test-types /Users/tilde/Downloads/oss/unist-util-assert
> dtslint types

Error: Cannot find module '/Users/tilde/.dts/typescript-installs/3.7/node_modules/typescript'
Require stack:
- /Users/tilde/Downloads/oss/unist-util-assert/node_modules/dtslint/bin/lint.js
- /Users/tilde/Downloads/oss/unist-util-assert/node_modules/dtslint/bin/index.js

(on Node 13.0.1 and npm 6.13.0). Any thoughts on why this is happening?

@ChristianMurphy
Copy link
Member Author

ChristianMurphy commented Nov 13, 2019

I've run into this before.
Usually it means something is off with the dtslint cache.
Running rm -rf ~/.dts/typescript-installs/3.7 ~/.dts/typescript-installs/next resolved the issue for me.

@wooorm
Copy link
Member

wooorm commented Nov 14, 2019

alright, released!

@wooorm wooorm added the 💪 phase/solved Post is done label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done 🧑 semver/major This is a change 🦋 type/enhancement This is great to have
Development

Successfully merging this pull request may close these issues.

3 participants