Skip to content

Fix bug with duplicate headings inside and outside the TOC tree #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

davidtheclark
Copy link
Contributor

Register the slug of every heading, even if it is before the TOC.
That way, if a heading within the TOC's tree is a duplicate of
one outside the TOC tree, the TOC's slug links still be accurate.

Closes #63.

Register the slug of every heading, even if it is before the TOC.
That way, if a heading within the TOC's tree is a duplicate of
one outside the TOC tree, the TOC's slug links still be accurate.

Closes syntax-tree#63.
Copy link
Member

@BarryThePenguin BarryThePenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating!

This looks good 👍

@wooorm wooorm merged commit d9646ce into syntax-tree:master Jan 13, 2020
@wooorm wooorm added ⛵️ status/released 🐛 type/bug This is a problem 👶 semver/patch This is a backwards-compatible fix 🗄 area/interface This affects the public interface labels Jan 13, 2020
@wooorm
Copy link
Member

wooorm commented Jan 13, 2020

Released as 5.0.1, thanks!

@wooorm wooorm added the 💪 phase/solved Post is done label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem
Development

Successfully merging this pull request may close these issues.

Duplicate headings inside and outside the TOC tree break TOC links
3 participants