Skip to content

Fix documentation of ruleRepetition option #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 23, 2020
Merged

Fix documentation of ruleRepetition option #9

merged 2 commits into from
Nov 23, 2020

Conversation

vweevers
Copy link
Contributor

To match:

mdast-util-to-markdown/lib/util/check-rule-repeat.js

Line 4 in 5fa790e

var repetition = context.options.ruleRepetition || 3

ChristianMurphy
ChristianMurphy approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, it also would need to be updated here:

mdast-util-to-markdown/types/index.d.ts

Line 74 in 5fa790e

ruleRepeat?: number

@wooorm
Copy link
Member

wooorm commented Nov 23, 2020

Thanks, weird! Seems ruleRepeat is also incorrectly in the types, could you update that too?

@wooorm
Copy link
Member

wooorm commented Nov 23, 2020

Not sure how this happened 😅 It’s not in any of the other projects

@wooorm wooorm merged commit cc35a88 into syntax-tree:main Nov 23, 2020
@wooorm wooorm added ☂️ area/types This affects typings ⛵️ status/released 👶 semver/patch This is a backwards-compatible fix 📚 area/docs This affects documentation 🦋 type/enhancement This is great to have labels Nov 23, 2020
@wooorm
Copy link
Member

wooorm commented Nov 23, 2020

Thanks Vincent, released!

@wooorm wooorm added the 💪 phase/solved Post is done label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm approved these changes

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

Assignees
No one assigned
Labels
📚 area/docs This affects documentation ☂️ area/types This affects typings 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vweevers @wooorm @ChristianMurphy