Add implementation #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remcohaszing
commented
Mar 16, 2023
remcohaszing
commented
Mar 16, 2023
remcohaszing
commented
Mar 16, 2023
wooorm
reviewed
Mar 16, 2023
Co-authored-by: Titus <tituswormer@gmail.com> Signed-off-by: Remco Haszing <remcohaszing@gmail.com>
remcohaszing
commented
Mar 16, 2023
Co-authored-by: Titus <tituswormer@gmail.com> Signed-off-by: Remco Haszing <remcohaszing@gmail.com>
This provides a more consistent interface between Node.js and the browser.
wooorm
approved these changes
Mar 16, 2023
|
I think it looks good. Anything you’d want me to look at specifically? Anything that needs to be discussed? |
|
I was mostly worried there might be discrepancies between the results in Node.js / the browser regarding fragment / document mode. HTML has so many edge cases 😅. I think it looks good though. At least good enough for my use case. |
|
The repo may need some settings changes to match the test of the unified ecosystem though. |
This comment was marked as resolved.
This comment was marked as resolved.
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
This adds the initial implementation of the package.
The idea comes from syntax-tree/hast-util-from-html#2